Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: convert externs.d.ts files to modules #12888

Merged
merged 1 commit into from
Aug 9, 2021
Merged

Conversation

brendankenny
Copy link
Member

fixes #12860

last follow up to #12870 and #12880.

Externs is a weird grab bag of stuff and should probably be organized further (e.g. type-utility helpers separated from random LH type defs?), but this mostly doesn't do that. The only big moves are moving LH.Trace/LH.TraceEvent/LH.DevtoolsLog over to artifacts.d.ts and LH.Locale to i18n.d.ts.

Everything else is just explicit export and global exposure in global-lh.d.ts as in the other two PRs.

Much cleaner review with ?w=1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

type issues with d.ts files
3 participants